8000 feat: add serviceName to 'child-process-gone' / app.getAppMetrics() by miniak · Pull Request #25975 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add serviceName to 'child-process-gone' / app.getAppMetrics() #25975

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 19, 2020
Merged

feat: add serviceName to 'child-process-gone' / app.getAppMetrics() #25975

merged 1 commit into from
Oct 19, 2020

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Oct 15, 2020 •
edited
Loading

Description of Change

It turns out that the name added in #24359 is localized. Add non-localized serviceName.

Checklist

Release Notes

Notes: Added non-localized serviceName to 'child-process-gone' / app.getAppMetrics().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 15, 2020
@miniak miniak self-assigned this Oct 15, 2020
@miniak miniak force-pushed the miniak/child-process-gone branch 3 times, most recently from c49bbe7 to c190e20 Compare October 15, 2020 20:51
@miniak miniak marked this pull request as ready for review October 15, 2020 20:56
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 16, 2020
@miniak miniak force-pushed the miniak/child-process-gone branch from c190e20 to e7046ea Compare October 18, 2020 01:52
@alexeykuzmin alexeykuzmin merged commit decb1eb into master Oct 19, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 19, 2020

Release Notes Persisted

Added non-localized serviceName to 'child-process-gone' / app.getAppMetrics().

@alexeykuzmin alexeykuzmin deleted the miniak/child-process-gone branch October 19, 2020 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @alexeykuzmin @codebytere
0