fix: maximized frameless window bleeding to other monitors #25940
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ckerr
approved these changes
Oct 14, 2020
deepak1556
reviewed
Oct 14, 2020
| insets->Set(0, frame_thickness, frame_thickness, frame_thickness); | ||
| } | ||
| // The insets would be eventually passed to WM_NCCALCSIZE, which takes | ||
| // the metrics under the DPI of _main_ monitor instead of current moniotr. |
There was a problem hiding this comment.
surprising find, should this be reported to upstream ?
There was a problem hiding this comment.
This only seems to be a problem for maximized frameless window, which Chrome only uses for deprecated Chrome Apps APIs. I can't find other way to reproduce it in Chrome .
deepak1556
approved these changes
Oct 14, 2020
|
Release Notes Persisted
|
|
I have automatically backported this PR to "10-x-y", please check out #25977 |
This was referenced Oct 15, 2020
|
I have automatically backported this PR to "11-x-y", please check out #25978 |
|
I have automatically backported this PR to "8-x-y", please check out #25979 |
|
I have automatically backported this PR to "9-x-y", please check out #25980 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This is a followup to #25052, to fix a bug on Windows that, maximized frameless window would have its edge bleeding to other monitors.
The previous fix did not work with multiple monitors with different DIPs, this PR should be able to fix that.
Note that this bug causes some maximized apps to consume much more GPU resources, and this PR is needed by old branches to fix the performance issue.
Fixes #25649
Checklist
npm testpassesRelease Notes
Notes: Fix maximized frameless window bleeding to other monitors.