8000 [GSoD] docs: revised the drag and drop feature page by bandantonio · Pull Request #25939 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

[GSoD] docs: revised the drag and drop feature page #25939

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Oct 16, 2020
Merged

[GSoD] docs: revised the drag and drop feature page #25939

merged 3 commits into from
Oct 16, 2020

Conversation

bandantonio
Copy link
Contributor

Description of Change

Revised the drag and drop feature page, fixed sample code, added animated image as an example

Checklist

Release Notes

Notes: Revised the drag and drop feature page with correct sample code and animated image as an example

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 14, 2020
ckerr
ckerr reviewed Oct 14, 2020
View reviewed changes
@bandantonio
Copy link
Contributor Author

@ckerr These are great comments, thank you!

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 15, 2020
erickzhao
erickzhao approved these changes Oct 15, 2020
View reviewed changes
Copy link
Member
@erickzhao erickzhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Two minor proofread changes.

@codebytere codebytere merged commit 55fdc17 into electron:master Oct 16, 2020
@release-clerk
Copy link
release-clerk bot commented Oct 16, 2020

Release Notes Persisted

Revised the drag and drop feature page with correct sample code and animated image as an example

erickzhao pushed a commit to erickzhao/ericktron that referenced this pull request Dec 1, 2020
@bandantonio @erickzhao
docs: revised the drag and drop feature page (electron#25939)
6e87a50 
* docs: revised the drag and drop feature page

* docs: fixed mentions in the drag and drop feature page

* docs: fixed mentions in the drag and drop feature page
@bandantonio bandantonio changed the title docs: revised the drag and drop feature page [GSoD] docs: revised the drag and drop feature page Dec 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@erickzhao erickzhao erickzhao approved these changes

Assignees
No one assigned
Labels
documentation 📓
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@bandantonio @ckerr @erickzhao @codebytere
0