8000 fix: submenu should be autoreleased by trop[bot] · Pull Request #25689 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: submenu should be autoreleased #25689

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 29, 2020
Merged

fix: submenu should be autoreleased #25689

merged 1 commit into from
Sep 29, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Sep 29, 2020

Backport of #25617

See that PR for details.

Notes: Fix memory leak when creating "Services" menu.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Sep 29, 2020
@trop trop bot requested a review from zcbenz September 29, 2020 16:57
@trop trop bot mentioned this pull request Sep 29, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Sep 29, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Sep 29, 2020
@jkleinsc jkleinsc merged commit 4c8eb34 into 9-x-y Sep 29, 2020
@release-clerk
Copy link
release-clerk bot commented Sep 29, 2020

Release Notes Persisted

Fix memory leak when creating "Services" menu.

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-fix-submenu-should-be-autoreleased-1601398648429 branch September 29, 2020 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @zcbenz
0