8000 fix: only notify mouse-up on mouse-up by codebytere · Pull Request #24240 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: only notify mouse-up on mouse-up #24240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

fix: only notify mouse-up on mouse-up #24240

merged 1 commit into from
Jun 23, 2020

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Jun 22, 2020 •
edited
Loading

Description of Change

Refs #24200.

Moved the mouse-up handler into handleClickEvents which it shouldn't have been. This does not need to go to 8 or 10, only 9, since it's been handled in the backports already (#24235).

cc @MarshallOfSound

Checklist

Release Notes

Notes: none.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 22, 2020
@codebytere codebytere merged commit acb64a2 into master Jun 23, 2020
@release-clerk
Copy link
release-clerk bot commented Jun 23, 2020

Release Notes Persisted

none.

@codebytere codebytere deleted the move-mouse-up branch June 23, 2020 15:37
@codebytere codebytere removed the new-pr 🌱 PR opened recently label Jun 23, 2020
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 23, 2020
@trop trop bot mentioned this pull request Jun 23, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Jun 23, 2020

I have automatically backported this PR to "9-x-y", please check out #24259

sentialx pushed a commit to sentialx/electron that referenced this pull request Jul 30, 2020
@codebytere @sentialx
fix: only notify mouse-up on mouse-up (electron#24240)
352c1d1
sentialx pushed a commit to sentialx/electron that referenced this pull request Apr 8, 2021
@codebytere @sentialx
fix: only notify mouse-up on mouse-up (electron#24240)
5bf4a27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
new-pr 🌱 PR opened recently
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0