10000 fix: emit click events with tray context menu by codebytere · Pull Request #24239 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: emit click events with tray context menu #24239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2020
Merged

fix: emit click events with tray context menu #24239

merged 1 commit into from
Jun 23, 2020

Conversation

codebytere
Copy link
Member

Backport of #24200

See that PR for details.

Notes: Fixed an issue with click events not being emitted on macOS for Trays with context menus set.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 22, 2020
@trop trop bot mentioned this pull request Jun 22, 2020
Merged
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jun 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 22, 2020
@codebytere codebytere requested a review from a team June 22, 2020 17:02
jkleinsc
jkleinsc approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codebytere codebytere merged commit 8c4c4fb into 8-x-y Jun 23, 2020
@release-clerk
Copy link
release-clerk bot commented Jun 23, 2020

Release Notes Persisted

Fixed an issue with click events not being emitted on macOS for Trays with context menus set.

@codebytere codebytere deleted the tray-emit-fix-8 branch June 23, 2020 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @jkleinsc
0