8000 docs: event.newGuest for new-window in WebContents and webContents in BrowsweWindow's constructor by trop[bot] · Pull Request #23356 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: event.newGuest for new-window in WebContents and webContents in BrowsweWindow's constructor #23356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 30, 2020

Backport of #21698

See that PR for details.

Notes: newGuest in new-window event of WebContents and webContents in BrowsweWindow constructor were well-documented.

According to the example codes in the documentation of `new-window`
event in `WebContents`, `webContents` in `BrowsweWindow` constructor
options and `newGuest` in `event` argument of `new-window` handler are
both existing but documented. This patch is for adding the related
documentations. Also, it provides typescript-definitations for these
two properties.
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 30, 2020
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 30, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 30, 2020
@ckerr ckerr merged commit b62df31 into 9-x-y Apr 30, 2020
@release-clerk
Copy link
release-clerk bot commented Apr 30, 2020

No Release Notes

@ckerr ckerr deleted the trop/9-x-y-bp-docs-event-newguest-for-new-window-in-webcontents-and-webcontents-in-browswewindow-s-constructor-1588263935390 branch April 30, 2020 20:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
9-x-y backport This is a backport PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0