8000 fix: set default menu in will-finish-launching event by trop[bot] · Pull Request #23263 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set default menu in will-finish-launching event #23263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 24, 2020
Merged

fix: set default menu in will-finish-launching event #23263

merged 1 commit into from
Apr 24, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 23, 2020

Backport of #23214

See that PR for details.

Notes: Fix win.setMenuBarVisibility(false) not hiding menu bar.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 23, 2020
@trop trop bot requested a review from zcbenz April 23, 2020 17:51
@trop trop bot mentioned this pull request Apr 23, 2020
Merged
5 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 23, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 23, 2020
@zcbenz zcbenz merged commit 69eddfb into 9-x-y Apr 24, 2020
@release-clerk
Copy link
release-clerk bot commented Apr 24, 2020

Release Notes Persisted

Fix win.setMenuBarVisibility(false) not hiding menu bar.

@zcbenz zcbenz deleted the trop/9-x-y-bp-fix-set-default-menu-in-will-finish-launching-event-1587664309894 branch April 24, 2020 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @zcbenz
0