8000 fix: ensure that functions are not retained beyond their context being released by MarshallOfSound · Pull Request #23232 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure that functions are not retained beyond their context being released #23232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 22, 2020
Merged

fix: ensure that functions are not retained beyond their context being released #23232

merged 1 commit into from
Apr 22, 2020

Conversation

MarshallOfSound
Copy link
Member

Backport of #23207

See that PR for details

Notes: fixed memory leak when using contextBridge with sandbox=true

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 22, 2020
@trop trop bot mentioned this pull request Apr 22, 2020
Merged
@trop trop bot added 7-2-x backport This is a backport PR labels Apr 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 22, 2020
@codebytere codebytere changed the title fix: ensure that functions are not retained beyond their context being released (#23207) fix: ensure that functions are not retained beyond their context being released Apr 22, 2020
@MarshallOfSound MarshallOfSound merged commit 3909001 into 7-2-x Apr 22, 2020
@release-clerk
Copy link
release-clerk bot commented Apr 22, 2020

Release Notes Persisted

fixed memory leak when using contextBridge with sandbox=true

@MarshallOfSound MarshallOfSound deleted the clean-up-function-store-on-context-release-7 branch April 22, 2020 22:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @codebytere
0