8000 fix: don't assign NSAlert to window which is not visible by trop[bot] · Pull Request #23090 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't assign NSAlert to window which is not visible #23090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Apr 17, 2020
Merged

fix: don't assign NSAlert to window which is not visible #23090

merged 3 commits into from
Apr 17, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 13, 2020

Backport of #22672

See that PR for details.

Notes: Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 13, 2020
@trop trop bot mentioned this pull request Apr 13, 2020
Merged
4 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels Apr 13, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 13, 2020
@codebytere codebytere merged commit ff6e411 into 9-x-y Apr 17, 2020
@release-clerk
Copy link
release-clerk bot commented Apr 17, 2020

Release Notes Persisted

Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS.

@codebytere codebytere deleted the trop/9-x-y-bp-fix-don-t-assign-nsalert-to-window-which-is-not-visible-1586766422062 branch April 17, 2020 03:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @CezaryKulakowski
0