8000 feat: add enableWebSQL webpreference by trop[bot] · Pull Request #23580 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add enableWebSQL webpreference #23580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 19, 2020
Merged

feat: add enableWebSQL webpreference #23580

merged 2 commits into from
May 19, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented May 13, 2020

Backport of #23311

See that PR for details.

Notes: enableWebSQL is a new webpreference option to enable/disable websql api

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 13, 2020
@trop trop bot requested a review from deepak1556 May 13, 2020 23:31
@trop trop bot mentioned this pull request May 13, 2020
Merged
6 tasks
@trop trop bot added 9-x-y backport This is a backport PR labels May 13, 2020
@deepak1556 deepak1556 requested review from a team and removed request for deepak1556 May 14, 2020 01:02
jkleinsc
jkleinsc requested changes May 14, 2020
View reviewed changes
Copy link
Member
@jkleinsc jkleinsc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking as request changes until after 9.0.0 is released as we are currently in a quiet period before the release

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 14, 2020
@jkleinsc
Copy link
Member

Merging as CI failure is flake unrelated to PR change.

@jkleinsc jkleinsc merged commit a02d3c8 into 9-x-y May 19, 2020
@release-clerk
Copy link
release-clerk bot commented May 19, 2020

Release Notes Persisted

enableWebSQL is a new webpreference option to enable/disable websql api

@jkleinsc jkleinsc deleted the trop/9-x-y-bp-feat-add-enablewebsql-webpreference-1589412660728 branch May 19, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
9-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkleinsc @deepak1556
0