8000 feat: programmatically modify traffic light positioning (#22533) by MarshallOfSound · Pull Request #22564 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: programmatically modify traffic light positioning (#22533) #22564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2020
Merged

feat: programmatically modify traffic light positioning (#22533) #22564

merged 1 commit into from
Mar 6, 2020

Conversation

MarshallOfSound
Copy link
Member

Backport of #22533

See that PR for details.

Notes: Added ability to set and get title bar traffic light position on the fly (macOS).

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 5, 2020
@trop trop bot mentioned this pull request Mar 5, 2020
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Mar 5, 2020
@MarshallOfSound MarshallOfSound force-pushed the traffic-light-set-pos-8 branch from 9f8c2fa to a5a0b5b Compare March 5, 2020 22:28
@MarshallOfSound
feat: programmatically modify traffic light positioning (#22533)
2d2d036 
* setter

* getter

* specs and docs

* fixup

Co-authored-by: Samuel Attard <samuel.r.attard@gmail.com>
@MarshallOfSound MarshallOfSound force-pushed the traffic-light-set-pos-8 branch from a5a0b5b to 2d2d036 Compare March 5, 2020 22:29
@MarshallOfSound
Copy link
Member Author

Approved by Releases WG 04/03/20

@nornagon
Copy link
Contributor
nornagon commented Mar 6, 2020

is this semver/minor?

@MarshallOfSound MarshallOfSound added the semver/minor backwards-compatible functionality label Mar 6, 2020
@MarshallOfSound MarshallOfSound merged commit b4e1b84 into 8-x-y Mar 6, 2020
@release-clerk
Copy link
release-clerk bot commented Mar 6, 2020

Release Notes Persisted

Added ability to set and get title bar traffic light position on the fly (macOS).

@MarshallOfSound MarshallOfSound deleted the traffic-light-set-pos-8 branch March 6, 2020 01:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR new-pr 🌱 PR opened recently semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarshallOfSound @nornagon
0