8000 fix: prevent potential modal window close segfault by codebytere · Pull Request #22481 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: prevent potential modal window close segfault #22481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2020
Merged

fix: prevent potential modal window close segfault #22481

merged 1 commit into from
Mar 3, 2020

Conversation

codebytere
Copy link
Member

Backport of #22410

See that PR for details.

Notes: Fixed an occasional segfault with modal windows being closed or destroyed.

@codebytere codebytere requested a review from a team March 2, 2020 19:33
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 2, 2020
@trop trop bot mentioned this pull request Mar 2, 2020
Merged
5 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Mar 2, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 2, 2020
@codebytere codebytere force-pushed the prevent-modal-death-8 branch from d445b83 to 4d1365b Compare March 2, 2020 20:46
@zcbenz zcbenz merged commit 6e46905 into 8-x-y Mar 3, 2020
@release-clerk
Copy link
release-clerk bot commented Mar 3, 2020

Release Notes Persisted

Fixed an occasional segfault with modal windows being closed or destroyed.

@zcbenz zcbenz deleted the prevent-modal-death-8 branch March 3, 2020 06:05
@carroarmato0 carroarmato0 mentioned this pull request Mar 13, 2020
Closed
@kenpowers-signal kenpowers-signal mentioned this pull request Mar 25, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @zcbenz
0