8000 feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary by trop[bot] · Pull Request #21297 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary #21297

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 16, 2020
Merged

feat: add session.addWordToSpellCheckerDictionary to allow custom words in the dictionary #21297

merged 3 commits into from
Jan 16, 2020

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Nov 26, 2019

Backport of #21266

See that PR for details.

Notes: Added session.addWordToSpellCheckerDictionary API to support custom words in the

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 26, 2019
@trop trop bot requested a review from MarshallOfSound November 26, 2019 21:17
@trop trop bot mentioned this pull request Nov 26, 2019
Merged
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 26, 2019
MarshallOfSound
MarshallOfSound requested changes Nov 26, 2019
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Blocking pending a vote in @electron/wg-releases

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 27, 2019
@MarshallOfSound
Merge branch '8-x-y' into trop/8-x-y-bp-feat-add-session-addwordtospe…
f8769b2 
…llcheckerdictionary-to-allow-custom-words-in-the-dictionary-1574803014419
@jkleinsc
Copy link
Member

Releases WG approves this backport fo 8-x-y.

@jkleinsc jkleinsc merged commit 048f06c into 8-x-y Jan 16, 2020
@release-clerk
Copy link
release-clerk bot commented Jan 16, 2020

Release Notes Persisted

Added session.addWordToSpellCheckerDictionary API to support custom words in the

@jkleinsc jkleinsc deleted the trop/8-x-y-bp-feat-add-session-addwordtospellcheckerdictionary-to-allow-custom-words-in-the-dictionary-1574803014419 branch January 16, 2020 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jkleinsc @zcbenz @MarshallOfSound
0