8000 fix: implement 'login' event for net.ClientRequest by nornagon · Pull Request #21133 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: implement 'login' event for net.ClientRequest #21133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Nov 26, 2019
Merged

fix: implement 'login' event for net.ClientRequest #21133

merged 12 commits into from
Nov 26, 2019

Conversation

nornagon
Copy link
Contributor

Backport of #21096. See that PR for details.

Notes: Fixed the 'login' event not being emitted when HTTP Basic auth was requested during a net.request.

@nornagon nornagon requested a review from a team as a code owner November 14, 2019 22:49
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Nov 14, 2019
@trop trop bot mentioned this pull request Nov 14, 2019
Merged
6 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Nov 14, 2019
@nornagon
Copy link
Contributor Author

NB: this includes #21098 to avoid having to resolve conflicts twice. Will rebase once that lands.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Nov 14, 2019
@nornagon nornagon force-pushed the backport/8-x-y/net-login branch 3 times, most recently from d815566 to bcd7cb5 Compare November 18, 2019 22:49
@nornagon nornagon force-pushed the backport/8-x-y/net-login branch from f3a0a50 to 161b2f3 Compare November 23, 2019 01:01
@MarshallOfSound MarshallOfSound merged commit 9d1ec6b into 8-x-y Nov 26, 2019
@release-clerk
Copy link
release-clerk bot commented Nov 26, 2019

Release Notes Persisted

Fixed the 'login' event not being emitted when HTTP Basic auth was requested during a net.request.

@MarshallOfSound MarshallOfSound deleted the backport/8-x-y/net-login branch November 26, 2019 19:32
@true-zero
Copy link

This issue was never resolved.

@true-zero
Copy link

#21323

@nornagon
Copy link
Contributor Author

@true-zero do you mean you're still encountering problems with the 'login' event? Or do you mean that #21323 should now be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nornagon @true-zero @MarshallOfSound
0