8000 fix: window.print() only working once by codebytere · Pull Request #21908 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: window.print() only working once #21908

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2020
Merged

fix: window.print() only working once #21908

merged 1 commit into from
Jan 28, 2020

Conversation

codebytere
Copy link
Member

Backport of #21893.

See that PR for more details.

Notes: Fixed an issue where window.print() only worked once on a single BrowserWindow.

@codebytere codebytere added backport This is a backport PR 8-x-y labels Jan 27, 2020
@codebytere codebytere requested a review from a team as a code owner January 27, 2020 19:43
@trop trop bot mentioned this pull request Jan 27, 2020
4 tasks
@codebytere codebytere requested review from jkleinsc and a team January 27, 2020 19:43
@codebytere
Copy link
Member Author

Windows failure is flake:

not ok 981 webContents module will-prevent-unload event emits if beforeunload returns false
  Error: Timeout of 30000ms exceeded. For async tests and hooks, ensure "done()" is called; if returning a Promise, ensure it resolves. (C:\projects\src\electron\spec-main\api-web-contents-spec.ts)
      at listOnTimeout (internal/timers.js:531:17)
      at processTimers (internal/timers.js:475:7)

@codebytere codebytere merged commit 473a90f into 8-x-y Jan 28, 2020
@release-clerk
Copy link
release-clerk bot commented Jan 28, 2020

Release Notes Persisted

Fixed an issue where window.print() only worked once on a single BrowserWindow.

@codebytere codebytere deleted the print-only-once-8 branch January 28, 2020 02:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@jkleinsc jkleinsc jkleinsc approved these changes

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@codebytere @ckerr @jkleinsc @zcbenz
0