8000 fix: recursive printing crash by codebytere · Pull Request #21905 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: recursive printing crash #21905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix: recursive printing crash #21905

merged 1 commit into from
Jan 27, 2020

Conversation

codebytere
Copy link
Member

Backport of #21889.

See that PR for details.

Notes: Fixed a crash in webContents.print() caused by infinite recursion.

@codebytere codebytere requested a review from a team as a code owner January 27, 2020 16:27
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 27, 2020
@trop trop bot mentioned this pull request Jan 27, 2020
Merged
4 tasks
@trop trop bot added 8-x-y backport This is a backport PR labels Jan 27, 2020
@codebytere codebytere requested a review from jkleinsc January 27, 2020 16:27
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 27, 2020
@codebytere codebytere merged commit bf64b34 into 8-x-y Jan 27, 2020
@release-clerk
Copy link
release-clerk bot commented Jan 27, 2020

Release Notes Persisted

Fixed a crash in webContents.print() caused by infinite recursion.

@codebytere codebytere deleted the recursive-fix-8 branch January 27, 2020 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

Assignees
No one assigned
Labels
8-x-y backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @jkleinsc
0