8000 fix: menu not updating with Tray.setContextMenu by zcbenz · Pull Request #21883 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: menu not updating with Tray.setContextMenu #21883

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 26, 2020
Merged

fix: menu not updating with Tray.setContextMenu #21883

merged 1 commit into from
Jan 26, 2020

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jan 24, 2020 •
edited
Loading

Description of Change

Close #21499.

Fix Tray.setContextMenu not updating the menu on Linux. This bug was introduced by a Chromium upgrade.

Test case is rather difficult to write since it requires manually clicking the DBus tray menu, so I have omitted it.

Checklist

Release Notes

Notes: Fix Tray.setContextMenu not updating the menu on Linux.

@zcbenz zcbenz requested review from ckerr and codebytere January 24, 2020 04:15
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 24, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 25, 2020
ckerr
ckerr approved these changes Jan 26, 2020
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed; I can no longer make OP's repro crash after applying this change

👍

@ckerr ckerr merged commit 2743d60 into master Jan 26, 2020
@release-clerk
Copy link
release-clerk bot commented Jan 26, 2020

Release Notes Persisted

Fix Tray.setContextMenu not updating the menu on Linux.

@ckerr ckerr deleted the fix-menu-not-update branch January 26, 2020 21:02
@trop trop bot mentioned this pull request Jan 26, 2020
Merged
@trop
Copy link
Contributor
trop bot commented Jan 26, 2020

I have automatically backported this PR to "8-x-y", please check out #21902

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

tray.setContextMenu(Menu.buildFromTemplate([...])) doesn't update the tray menu and the app segfaults if menu item clicked several times
4 participants
@zcbenz @ckerr @deepak1556 @codebytere
0