8000 fix: call SetCanActivate in setFocusable by zcbenz · Pull Request #21856 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: call SetCanActivate in setFocusable #21856

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 22, 2020
Merged

fix: call SetCanActivate in setFocusable #21856

merged 1 commit into from
Jan 22, 2020

Conversation

zcbenz
Copy link
Contributor
@zcbenz zcbenz commented Jan 22, 2020

Backport of #21846.

Notes: Fix BrowserWindow.setFocusable(true) not working on Windows.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jan 22, 2020
@trop trop bot mentioned this pull request Jan 22, 2020
Merged
6 tasks
@trop trop bot added 6-1-x backport This is a backport PR labels Jan 22, 2020
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jan 22, 2020
@zcbenz zcbenz force-pushed the fix-win-focus-6-1-x branch from 3bfc7ac to deae146 Compare January 22, 2020 02:27
@zcbenz zcbenz force-pushed the fix-win-focus-6-1-x branch from deae146 to ed4354a Compare January 22, 2020 04:29
@zcbenz zcbenz merged commit 7a65aeb into 6-1-x Jan 22, 2020
@release-clerk
Copy link
release-clerk bot commented Jan 22, 2020

Release Notes Persisted

Fix BrowserWindow.setFocusable(true) not working on Windows.

@zcbenz zcbenz deleted the fix-win-focus-6-1-x branch January 22, 2020 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
6-1-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zcbenz @deepak1556
0