8000 fix: HTML5 fullscreen APIs not working in <webview> by miniak · Pull Request #20432 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: HTML5 fullscreen APIs not working in <webview> #20432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix: HTML5 fullscreen APIs not working in <webview> #20432

merged 1 commit into from
Oct 7, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Oct 4, 2019 •
edited
Loading

Description of Change

Fixes #16428

NativeWindowRelay::FromWebContents() was using UserDataKey() while NativeWindowRelay::CreateForWebContents() was using kNativeWindowRelayUserDataKey.
This would lead to the <webview> not having an owner window set, which would blow up in CommonWebContentsDelegate::EnterFullscreenModeForTab().

This was fixed in 5-0-x by d5c37c3

Checklist

Release Notes

Notes: Fixed HTML5 fullscreen APIs not working in <webview>.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 4, 2019
@miniak miniak self-assigned this Oct 4, 2019
@miniak miniak added the 4-2-x label Oct 4, 2019
@miniak miniak force-pushed the miniak/fix-webview-fullscreen branch from 391edd1 to 96ec0c4 Compare October 4, 2019 22:29
@miniak miniak requested a review from deepak1556 October 4, 2019 22:33
deepak1556
deepak1556 approved these changes Oct 4, 2019
View reviewed changes
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@miniak miniak requested a review from alexeykuzmin October 5, 2019 17:19
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 5, 2019
@codebytere codebytere merged commit c344eca into 4-2-x Oct 7, 2019
@release-clerk
Copy link
release-clerk bot commented Oct 7, 2019

Release Notes Persisted

Fixed HTML5 fullscreen APIs not working in <webview>.

@codebytere codebytere deleted the miniak/fix-webview-fullscreen branch October 7, 2019 12:47
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
4-2-x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @deepak1556 @codebytere
0