8000 fix: fs.watch() behavior change in node >= 10.16.0 by deepak1556 · Pull Request #20430 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: fs.watch() behavior change in node >= 10.16.0 #20430

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 7, 2019
Merged

fix: fs.watch() behavior change in node >= 10.16.0 #20430

merged 1 commit into from
Oct 7, 2019

Conversation

deepak1556
Copy link
Member
@deepak1556 deepak1556 commented Oct 4, 2019 •
edited
Loading

Description of Change

Backports #20408

Checklist

Release Notes

Notes: fix fs.watch behavior change in node >=10.16.0

@deepak1556
fix: fs.watch() behavior change in node >= 10.16.0
6b30a71 
This reverts the patch from electron/node#100
which never got merged due to reasons outlined in libuv/libuv#2313

* Adds new patches that backports libuv/libuv#2459
  and libuv/libuv#2460

Based on nodejs/node#29460
@deepak1556 deepak1556 requested a review from a team as a code owner October 4, 2019 21:44
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Oct 4, 2019
@trop trop bot mentioned this pull request Oct 4, 2019
Merged
6 tasks
@trop trop bot added 7-0-x backport This is a backport PR labels Oct 4, 2019
@deepak1556 deepak1556 requested a review from a team October 4, 2019 21:44
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Oct 4, 2019
@deepak1556 deepak1556 merged commit 77af675 into 7-0-x Oct 7, 2019
@release-clerk
Copy link
release-clerk bot commented Oct 7, 2019

Release Notes Persisted

fix fs.watch behavior change in node >=10.16.0

@deepak1556 deepak1556 deleted the fix_libuv_fsevents-7.x branch October 7, 2019 20:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
7-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@deepak1556 @codebytere
0