feat: allow setting capture mode and max file size in netLog API #19215
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zcbenz
suggested changes
Jul 15, 2019
|
The test is failing in CI because of the reasoning stated in the PR description; this depends on a Chromium roll to be fixed. |
zcbenz
approved these changes
Jul 16, 2019
3642e2d to
14c84f6
Compare
|
Release Notes Persisted
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds two new options to
netLog.startLogging:maxFileSizeandcaptureMode.NB. the names of the capture modes changed recently: https://chromium-review.googlesource.com/c/chromium/src/+/1685684. This PR uses the new names, and depends on that PR to fix the decoding of the "EVERYTHING" capture mode, which until that PR was decoded on the receiving mojo end as if it were the "INCLUDE_PRIVACY_INFO" capture mode.
Checklist
npm testpassesRelease Notes
Notes: Added
captureModeandmaxFileSizeoptions to the netLog API.