8000 fix: handle no env in externsion world set up by trop[bot] · Pull Request #19105 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: handle no env in externsion world set up #19105

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

fix: handle no env in externsion world set up #19105

merged 1 commit into from
Jul 3, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jul 3, 2019

Backport of #19101

See that PR for details.

Notes: Fixed crash that could occur while certain chrome devtools extensions were loaded.

@MarshallOfSound @electron-bot
fix: handle no env in externsion world set up
396423f 
Previously when GetEnvironment returned null this extension setup
crashed.
@trop trop bot mentioned this pull request J 8000 ul 3, 2019
Merged
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jul 3, 2019
@trop trop bot added 6-0-x backport This is a backport PR labels Jul 3, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jul 3, 2019
@MarshallOfSound MarshallOfSound merged commit 1c2b8f8 into 6-0-x Jul 3, 2019
@release-clerk
Copy link
release-clerk bot commented Jul 3, 2019

Release Notes Persisted

Fixed crash that could occur while certain chrome devtools extensions were loaded.

@MarshallOfSound MarshallOfSound deleted the trop/6-0-x-bp-fix-handle-no-env-in-externsion-world-set-up-1562193739836 branch July 3, 2019 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@MarshallOfSound
0