8000 fix: command-line scheme switch values' spillover by ckerr · Pull Request #19954 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: command-line scheme switch values' spillover #19954

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 26, 2019
Merged

fix: command-line scheme switch values' spillover #19954

merged 1 commit into from
Aug 26, 2019

Conversation

ckerr
Copy link
Member
@ckerr ckerr commented Aug 26, 2019

Description of Change

Manually backport #19912

See that PR for details.

CC @codebytere

Checklist

Release Notes

Notes: Fixed command-line scheme arguments from spilling over into each other.

@ckerr ckerr requested a review from codebytere August 26, 2019 20:19
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 26, 2019
@trop trop bot mentioned this pull request Aug 26, 2019
Merged
5 tasks
codebytere
codebytere approved these changes Aug 26, 2019
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ pending green CI!

@codebytere codebytere added 4-2-x backport This is a backport PR and removed new-pr 🌱 PR opened recently labels Aug 26, 2019
@codebytere codebytere merged commit 8181f57 into 4-2-x Aug 26, 2019
@release-clerk
Copy link
release-clerk bot commented Aug 26, 2019

Release Notes Persisted

Fixed command-line scheme arguments from spilling over into each other.

@codebytere codebytere deleted the fix-command-line-schemes-splillover_4-2-x branch August 26, 2019 21:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
4-2-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckerr @codebytere
0