10000 fix: use WeakPtr to detect deletion to avoid crash on application menu by jkleinsc · Pull Request #19561 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: use WeakPtr to detect deletion to avoid crash on application menu #19561

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 1, 2019
Merged

fix: use WeakPtr to detect deletion to avoid crash on application menu #19561

merged 1 commit into from
Aug 1, 2019

Conversation

jkleinsc
Copy link
Member
@jkleinsc jkleinsc commented Aug 1, 2019 •
edited
Loading

Manual backport of #19257
(cherry picked from commit 4bcf99d)

Description of Change

Checklist

Release Notes

Notes: Fixed crashes when using the application menu on Linux.

fix: use WeakPtr to detect deletion
2aa5c4a 
(cherry picked from commit 4bcf99d)
@jkleinsc jkleinsc requested a review from a team as a code owner August 1, 2019 00:16
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Aug 1, 2019
@trop trop bot mentioned this pull request Aug 1, 2019
Merged
4 tasks
@codebytere codebytere added 5-0-x backport This is a backport PR and removed new-pr 🌱 PR opened recently labels Aug 1, 2019
@MarshallOfSound MarshallOfSound merged commit 3af498e into 5-0-x Aug 1, 2019
@release-clerk
Copy link
release-clerk bot commented Aug 1, 2019

Release Notes Persisted

Fixed crashes when using the application menu on Linux.

@MarshallOfSound MarshallOfSound deleted the fix-linux-menu-crash-5-0-x branch August 1, 2019 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jkleinsc @ckerr @MarshallOfSound @codebytere
0