8000 fix: reverse showSaveDialog cancellation bool by trop[bot] · Pull Request #18383 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: reverse showSaveDialog cancellation bool #18383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 21, 2019
Merged

fix: reverse showSaveDialog cancellation bool #18383

merged 1 commit into from
May 21, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented May 21, 2019

Backport of #18366

See that PR for details.

Notes: Corrected a reversal of cancellation values in showSaveDialog on the Windows platform.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 21 8000 , 2019
@trop trop bot mentioned this pull request May 21, 2019
Merged
4 tasks
@trop trop bot added 6-0-x backport This is a backport PR labels May 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 21, 2019
@ckerr ckerr merged commit 84b762f into 6-0-x May 21, 2019
@release-clerk
Copy link
release-clerk bot commented May 21, 2019

Release Notes Persisted

Corrected a reversal of cancellation values in showSaveDialog on the Windows platform.

@ckerr ckerr deleted the trop/6-0-x-bp-fix-reverse-showsavedialog-cancellation-bool-1558453934524 branch May 21, 2019 18:09
@MarshallOfSound MarshallOfSound mentioned this pull request May 22, 2019
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckerr @codebytere
0