8000 fix: set window to null when no window is passed by trop[bot] · Pull Request #18381 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: set window to null when no window is passed #18381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 21, 2019
Merged

fix: set window to null when no window is passed #18381

merged 3 commits into from
May 21, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented May 21, 2019

Backport of #18240

See that PR for details.

Notes: Fixed a dialog crash when no BrowserWindow was passed.

@trop trop bot mentioned this pull request May 21, 2019
Merged
6 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 21, 2019
@trop trop bot added 6-0-x backport This is a backport PR labels May 21, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 21, 2019
@codebytere codebytere merged commit 043838f into 6-0-x May 21, 2019
@release-clerk
Copy link
release-clerk bot commented May 21, 2019

Release Notes Persisted

Fixed a dialog crash when no BrowserWindow was passed.

@codebytere codebytere deleted the trop/6-0-x-bp-fix-set-window-to-null-when-no-window-is-passed-1558447714054 branch May 21, 2019 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ckerr @codebytere
0