10000 docs: update sandbox-option.md by miniak · Pull Request #18275 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: update sandbox-option.md #18275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 20, 2019
Merged

docs: update sandbox-option.md #18275

merged 2 commits into from
May 20, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented May 13, 2019 •
edited
Loading

Description of Change

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • relevant documentation is changed or added
  • PR title follows semantic commit guidelines

Release Notes

Notes: no-notes

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 13, 2019
@miniak miniak self-assigned this May 13, 2019
miniak
miniak commented May 13, 2019
View reviewed changes
ppontes
ppontes approved these changes May 13, 2019
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 14, 2019
@miniak miniak force-pushed the miniak/sandbox-option branch from e622994 to 3070928 Compare May 14, 2019 17:49
@miniak miniak force-pushed the miniak/sandbox-option branch from 3070928 to f39e5c9 Compare May 14, 2019 17:54
@miniak miniak requested review from nornagon and a team May 15, 2019 19:33
malept
malept reviewed May 19, 2019
View reviewed changes
@miniak @malept
Update docs/api/sandbox-option.md
e8d0a1e 
Co-Authored-By: Mark Lee <malept@users.noreply.github.com>
@alexeykuzmin alexeykuzmin merged commit dbb8617 into master May 20, 2019
@release-clerk
Copy link
release-clerk bot commented May 20, 2019

No Release Notes

@alexeykuzmin alexeykuzmin deleted the miniak/sandbox-option branch May 20, 2019 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@malept malept malept left review comments

@ppontes ppontes ppontes approved these changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@zcbenz zcbenz zcbenz approved these changes

@nornagon nornagon Awaiting requested review from nornagon

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@miniak @malept @alexeykuzmin @zcbenz @ppontes
0