8000 fix: Windows logger path by nitsakh · Pull Request #18199 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: Windows logger path #18199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 20, 2019
Merged

fix: Windows logger path #18199

merged 1 commit into from
May 20, 2019

Conversation

nitsakh
Copy link
Contributor
@nitsakh nitsakh commented May 7, 2019 •
edited
Loading

Description of Change

Windows debug isn't logging because of a DCHECK failure during startup. This changes the logger initialization to use the absolute path, so that logging works again.
Fixes #13770 (comment)

Checklist

Release Notes

Notes: Fixed windows debug logging

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 7, 2019
@nitsakh nitsakh requested a review from deepak1556 May 7, 2019 19:17
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels May 8, 2019
@electron-cation electron-cation bot added new-pr 🌱 PR opened recently and removed new-pr 🌱 PR opened recently labels May 8, 2019
@codebytere
Copy link
Member

@nitsakh would you mind rebasing on master to get rid of the GitHub Actions explosion?

@nitsakh
fix: Windows logger path
03eb001 
Windows debug isn't logging because of a DCHECK failure during startup. This changes the logger initialization to use the absolute path, so that logging works again.
deepak1556
deepak1556 approved these changes May 10, 2019
View reviewed changes
Copy link
Member
@deepak1556 deepak1556 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is only useful in development, so I am good with it being relative to the executable path.

@nitsakh nitsakh merged commit 9c21c66 into master May 20, 2019
@release-clerk
Copy link
release-clerk bot commented May 20, 2019

Release Notes Persisted

Fixed windows debug logging

@nitsakh nitsakh deleted the fix-win-logger branch May 20, 2019 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkleinsc jkleinsc jkleinsc approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Re-enable mixed-sandbox tests for Windows CI
4 participants
@nitsakh @codebytere @jkleinsc @deepak1556
0