8000 fix: do not mark navigations interupted with same-document navigations as aborted by MarshallOfSound · Pull Request #18109 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: do not mark navigations interupted with same-document navigations as aborted #18109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 3, 2019
Merged

fix: do not mark navigations interupted with same-document navigations as aborted #18109

merged 2 commits into from
May 3, 2019

Conversation

MarshallOfSound
Copy link
Member

Fixes #17526

This is probably the closest thing we can get to something that makes everyone happy. Virtual navigations are now ignored, actually interrupting the loadURL call with another loadURL call still correctly rejects the first promise.

Notes: Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@MarshallOfSound MarshallOfSound requested a review from nornagon May 1, 2019 22:34
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 1, 2019
@deepak1556
Copy link
Member

Can you add a spec based on the issue sample. Thanks!

@vladimiry
Copy link

Also please consider making ERR_ABORTED error message a little more detailed.

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 2, 2019
@MarshallOfSound MarshallOfSound force-pushed the do-not-abort-virtual-routing branch from dbc93e6 to 91e6985 Compare May 3, 2019 22:04
@MarshallOfSound MarshallOfSound merged commit 636273b into master May 3, 2019
@release-clerk
Copy link
release-clerk bot commented May 3, 2019

Release Notes Persisted

Fixed case where the promise returned by loadURL and loadFile would be rejected with ERR_ABORTED if you triggered a virtual navigation before the page had finished loading. E.g. Used history.pushState or set location.hash

@MarshallOfSound MarshallOfSound deleted the do-not-abort-virtual-routing branch May 3, 2019 23:19
@trop trop bot mentioned this pull request May 3, 2019
Merged
@trop
Copy link
Contributor
trop bot commented May 3, 2019

I have automatically backported this PR to "5-0-x", please check out #18142

@trop trop bot mentioned this pull request May 3, 2019
Merged
@trop
Copy link
Contributor
trop bot commented May 3, 2019

I have automatically backported this PR to "6-0-x", please check out #18143

kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@MarshallOfSound @kiku-jw
fix: do not mark navigations interupted with same-document navigation…
ee3ff87 
…s as aborted (electron#18109)

* fix: do not mark navigations interupted with same-document navigations as aborted

* spec: add tests for the loadURL promise
@vladimiry vladimiry mentioned this pull request Jun 15, 2020
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nornagon nornagon nornagon approved these changes

@deepak1556 deepak1556 deepak1556 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

loadURL / loadFile calls throw "ERR_ABORTED (-3) error" if location.hash or history.pushState called on the page before page loaded
5 participants
@MarshallOfSound @deepak1556 @vladimiry @nornagon @codebytere
0