8000 fix: ensure the inspector agent is shutdown before cleaning up the node env by trop[bot] · Pull Request #18077 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: ensure the inspector agent is shutdown before cleaning up the node env #18077

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
May 1, 2019
Merged

fix: ensure the inspector agent is shutdown before cleaning up the node env #18077

merged 3 commits into from
May 1, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 30, 2019

Backport of #18028

See that PR for details.

Notes: Fixed crash when quitting Electron with an inspector attached

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 30, 2019
@trop trop bot mentioned this pull request Apr 30, 2019
Merged
@trop trop bot added 6-0-x backport This is a backport PR labels Apr 30, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 30, 2019
@codebytere codebytere merged commit be16a19 into 6-0-x May 1, 2019
@release-clerk
Copy link
release-clerk bot commented May 1, 2019

Release Notes Persisted

Fixed crash when quitting Electron with an inspector attached

@codebytere codebytere deleted the trop/6-0-x-bp-fix-ensure-the-inspector-agent-is-shutdown-before-cleaning-up-the-node-env-1556664300662 branch May 1, 2019 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0