8000 fix: make isDarkMode correctly detect dark mode in the auto setting on catalina by trop[bot] · Pull Request #18960 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: make isDarkMode correctly detect dark mode in the auto setting on catalina #18960

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2019
Merged

fix: make isDarkMode correctly detect dark mode in the auto setting on catalina #18960

merged 1 commit into from
Jun 24, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Jun 24, 2019

Backport of #18949

See that PR for details.

Notes: systemPreferences.isDarkMode() now correctly detects dark mode on macOS Catalina

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 24, 2019
@trop trop bot mentioned this pull request Jun 24, 2019
Merged
@trop trop bot added 5-0-x backport This is a backport PR labels Jun 24, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 24, 2019
@codebytere codebytere merged commit 0c4b2e9 into 5-0-x Jun 24, 2019
@release-clerk
Copy link
release-clerk bot commented Jun 24, 2019

Release Notes Persisted

systemPreferences.isDarkMode() now correctly detects dark mode on macOS Catalina

@codebytere codebytere deleted the trop/5-0-x-bp-fix-make-isdarkmode-correctly-detect-dark-mode-in-the-auto-setting-on-catalina-1561396677675 branch June 24, 2019 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0