8000 refactor: make savePath a property on DownloadItem by codebytere · Pull Request #18677 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: make savePath a property on DownloadItem #18677

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2019
Merged

refactor: make savePath a property on DownloadItem #18677

merged 2 commits into from
Jun 20, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Jun 6, 2019 •
edited
Loading

Description of Change

Converted item.savePath on DownloadItem to a bespoke property.

cc @miniak @zcbenz

Checklist

Release Notes

Notes: Converted savePath accessor to a property on DownloadItem instances.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 6, 2019
8000
@codebytere codebytere added the semver/minor backwards-compatible functionality label Jun 6, 2019
MarshallOfSound
MarshallOfSound reviewed Jun 6, 2019
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 7, 2019
miniak
miniak requested changes Jun 16, 2019
View reviewed changes
Copy link
Contributor
@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

saveDialogOptions should not be property as pointed out by @zcbenz on slack

@codebytere codebytere changed the title refactor: make savePath and saveDialogOptions properties on DownloadItem refactor: make savePath a property on DownloadItem Jun 18, 2019
@codebytere codebytere requested a review from miniak June 18, 2019 04:42
@codebytere codebytere merged commit 5363271 into master Jun 20, 2019
@release-clerk
Copy link
release-clerk bot commented Jun 20, 2019

Release Notes Persisted

Converted savePath accessor to a property on DownloadItem instances.

@codebytere codebytere deleted the dl-item-props branch June 20, 2019 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @miniak @MarshallOfSound
0