8000 feat: allow resigning current NSUserActivity by codebytere · Pull Request #18659 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: allow resigning current NSUserActivity #18659

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 7, 2019
Merged

feat: allow resigning current NSUserActivity #18659

merged 2 commits into from
Jun 7, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Jun 5, 2019 •
edited
Loading

Description of Change

Closes #9622 by addressing last outstanding API request.

This PR adds a method to the app module: app.resignCurrentActivity(). This new method allows for the current Handoff user activity to be marked as inactive without invalidating it.

cc @miniak @nornagon @zcbenz

Checklist

Release Notes

Notes: Added a method app.resignCurrentActivity() to allows marking inactive the current Handoff user activity without invalidating it.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 5, 2019
@codebytere codebytere added semver/minor backwards-compatible functionality enhancement ✨ platform/macOS labels Jun 5, 2019
@codebytere codebytere mentioned this pull request Jun 5, 2019
Closed
@codebytere codebytere changed the title [wip] feat: allow resigning current NSUserActivity feat: allow resigning current NSUserActivity Jun 5, 2019
@codebytere codebytere force-pushed the resign-current-activity branch from 2a65a28 to b8ba338 Compare June 6, 2019 02:31
@codebytere codebytere force-pushed the resign-current-activity branch from b8ba338 to 211f50a Compare June 6, 2019 02:42
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 6, 2019
@codebytere codebytere merged commit abab90f into master Jun 7, 2019
@release-clerk
Copy link
release-clerk bot commented Jun 7, 2019

Release Notes Persisted

Added a method app.resignCurrentActivity() to allows marking inactive the current Handoff user activity without invalidating it.

@codebytere codebytere deleted the resign-current-activity branch June 7, 2019 05:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

Assignees
No one assigned
Labels
enhancement ✨ platform/macOS semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve Handoff API support
2 participants
@codebytere @zcbenz
0