8000 fix: don't export private V8 symbols that can cause native node modules to crash by miniak · Pull Request #18619 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't export private V8 symbols that can cause native node modules to crash #18619

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 4, 2019
Merged

fix: don't export private V8 symbols that can cause native node modules to crash #18619

merged 1 commit into from
Jun 4, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jun 4, 2019

Description of Change

Backport of #18281

Checklist

Release Notes

Notes: Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@miniak miniak requested a review from a team as a code owner June 4, 2019 06:23
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 4, 2019
@trop trop bot mentioned this pull request Jun 4, 2019
Merged
4 tasks
@miniak miniak added 6-0-x backport This is a backport PR labels Jun 4, 2019
@miniak miniak requested a review from a team June 4, 2019 06:27
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 4, 2019
@miniak miniak force-pushed the miniak/backport-v8-private-symbols-6-0-x branch from d29759b to 7b7f811 Compare June 4, 2019 06:43
@ckerr ckerr merged commit b2ea1bc into 6-0-x Jun 4, 2019
@release-clerk
Copy link
release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Removed incorrectly published internal V8 symbols and CRT methods from node.lib, causing heap corruptions with node modules using the dynamic CRT on Windows.

@ckerr ckerr deleted the miniak/backport-v8-private-symbols-6-0-x branch June 4, 2019 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@torycl torycl torycl approved these changes

Assignees

@torycl torycl

Labels
6-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @codebytere @torycl @ckerr
0