8000 fix: UAP in ImageBitmapLoader/FileReaderLoader by miniak · Pull Request #18563 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: UAP in ImageBitmapLoader/FileReaderLoader #18563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Jun 4, 2019
Merged

fix: UAP in ImageBitmapLoader/FileReaderLoader #18563

merged 4 commits into from
Jun 4, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Jun 1, 2019 •
edited
Loading

Description of Change

Backport fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913970
https://chromium.googlesource.com/chromium/src.git/+/419c4bfbfb94849ed30dcab7c3aaf67afe238b27

Fix UAP in ImageBitmapLoader/FileReaderLoader

FileReaderLoader stores its client as a raw pointer, so in cases like
ImageBitmapLoader where the FileReaderLoaderClient really is garbage
collected we have to make sure to destroy the FileReaderLoader when
the ExecutionContext that owns it is destroyed.

/cc @electron/wg-security

Checklist

Release Notes

Notes: Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913970.

@miniak miniak added the 4-2-x label Jun 1, 2019
@miniak miniak requested a review from a team June 1, 2019 21:18
@miniak miniak self-assigned this Jun 1, 2019
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Jun 1, 2019
@miniak miniak changed the title fix: Issue 913970: UAP in blink::FileReaderLoader::OnStartLoading fix: Fix UAP in ImageBitmapLoader/FileReaderLoader Jun 1, 2019
@miniak miniak changed the title fix: Fix UAP in ImageBitmapLoader/FileReaderLoader fix: UAP in ImageBitmapLoader/FileReaderLoader Jun 1, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Jun 2, 2019
@miniak miniak added security 🔒 backport This is a backport PR labels Jun 3, 2019
@codebytere
Copy link
Member

@miniak can you please fix conflicts?

@miniak
Copy link
Contributor Author
miniak commented Jun 4, 2019

@codebytere ready to merge

@codebytere codebytere merged commit b35e35f into 4-2-x Jun 4, 2019
@release-clerk
Copy link
release-clerk bot commented Jun 4, 2019

Release Notes Persisted

Backported fix for https://bugs.chromium.org/p/chromium/issues/detail?id=913970.

@codebytere codebytere deleted the miniak/backport-913970-4-2-x branch June 4, 2019 18:22
756B
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zcbenz zcbenz zcbenz approved these changes

@codebytere codebytere codebytere approved these changes

Assignees

@miniak miniak

Labels
4-2-x backport This is a backport PR security 🔒
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @codebytere @zcbenz
0