8000 fix: don't package mojom{,-lite}.js files in dist.zip by nornagon · Pull Request #18444 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: don't package mojom{,-lite}.js files in dist.zip #18444

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 28, 2019
Merged

fix: don't package mojom{,-lite}.js files in dist.zip #18444

merged 1 commit into from
May 28, 2019

Conversation

nornagon
Copy link
Contributor

Description of Change

These files aren't needed for Electron to run. I believe the dependency on them is in error in Chromium, but I'm not sure what the right upstream fix is for now so just masking them out in zip.py.

Checklist

Release Notes

Notes: Removed inadvertently included mojom.js files from distribution bundle.

@nornagon nornagon requested a review from jkleinsc May 24, 2019 18:08
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label May 24, 2019
@nornagon nornagon force-pushed the skip-mojom-js-dist branch from bccea56 to 59aeb9f Compare May 24, 2019 22:12
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label May 25, 2019
@nornagon nornagon merged commit 2923ae8 into master May 28, 2019
@release-clerk
Copy link
release-clerk bot commented May 28, 2019

Release Notes Persisted

Removed inadvertently included mojom.js files from distribution bundle.

@nornagon
Copy link
Contributor Author

/trop run backport-to 6-0-x

@trop
Copy link
Contributor
trop bot commented May 28, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "6-0-x" here we go! :D

@trop trop bot mentioned this pull request May 28, 2019
Merged
@trop
Copy link
Contributor
trop bot commented May 28, 2019

I have automatically backported this PR to "6-0-x", please check out #18486

@trop trop bot added the in-flight/6-0-x label May 28, 2019
@nornagon nornagon deleted the skip-mojom-js-dist branch May 28, 2019 21:11
@miniak
Copy link
Contributor
miniak commented Jul 9, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor
trop bot commented Jul 9, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop trop bot mentioned this pull request Jul 9, 2019
Closed
@trop
Copy link
Contributor
trop bot commented Jul 9, 2019

I have automatically backported this PR to "5-0-x", please check out #19176

@trop trop bot added the in-flight/5-0-x label Jul 9, 2019
@miniak
Copy link
Contributor
miniak commented Jul 9, 2019

/trop run backport-to 4-2-x

@trop
Copy link
Contributor
trop bot commented Jul 9, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "4-2-x" here we go! :D

@trop trop bot mentioned this pull request Jul 9, 2019
Closed
@trop
Copy link
Contributor
trop bot commented Jul 9, 2019

I have automatically backported this PR to "4-2-x", please check out #19178

@trop trop bot added the in-flight/4-2-x label Jul 9, 2019
@miniak
Copy link
Contributor
miniak commented Jul 10, 2019

/trop run backport-to 5-0-x

@trop
Copy link
Contributor
trop bot commented Jul 10, 2019

The backport process for this PR has been manually initiated,
sending your 1's and 0's to "5-0-x" here we go! :D

@trop
Copy link
Contributor
trop bot commented Jul 10, 2019

I have automatically backported this PR to "5-0-x", please check out #19192

@trop trop bot mentioned this pull request Jul 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@jkleinsc jkleinsc Awaiting requested review from jkleinsc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nornagon @miniak @MarshallOfSound
0