8000 feat: add tray.getTitle() by codebytere · Pull Request #17385 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add tray.getTitle() #17385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 18, 2019
Merged

feat: add tray.getTitle() #17385

merged 2 commits into from
Mar 18, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 14, 2019 •
edited
Loading

Description of Change

This PR adds a getter for the tray title on macOS. This allows a user to programmatically ensure that setTitle took effect as well as acting as a precursor for making title a property on the Tray module, which would necessitate both a getter and setter where only a setter existed before.

Also cleans up methods within defines so that the title setter and getter don't have to be implemented cross-platform emptily.

cc @nornagon @MarshallOfSound

Checklist

Release Notes

Notes: Added tray.getTitle() to allows users to see the title set next to the status bar icon on macOS.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 14, 2019
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 14, 2019
MarshallOfSound
MarshallOfSound reviewed Mar 14, 2019
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add a spec to ensure that setting then getting does as expected 👍

@codebytere
Copy link
Member Author

@MarshallOfSound done!

@codebytere codebytere changed the title feat: add tray.getTitle feat: add tray.getTitle() Mar 14, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 15, 2019
@codebytere codebytere merged commit 2fb9085 into master Mar 18, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 18, 2019

Release Notes Persisted

Added tray.getTitle() to allows users to see the title set next to the status bar icon on macOS.

@codebytere codebytere deleted the tray-gettitle branch March 18, 2019 19:40
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: add tray.getTitle() (electron#17385)
c3404ac 
* feat: add tray.getTitle

* fix spec
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound left review comments

@miniak miniak miniak approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @miniak @MarshallOfSound
0