8000 feat: add systemPreferences.getAnimationSettings() by miniak · Pull Request #17382 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add systemPreferences.getAnimationSettings() #17382

New issue 8000

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 19, 2019
Merged

feat: add systemPreferences.getAnimationSettings() #17382

merged 1 commit into from
Mar 19, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Mar 14, 2019

Description of Change

Expose system animation settings provided by https://cs.chromium.org/chromium/src/ui/gfx/animation/animation.h

Checklist

Release Notes

Notes: Added systemPreferences.getAnimationSettings() returning system animation settings provided by Chromium.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 14, 2019
@miniak miniak self-assigned this Mar 14, 2019
@codebytere
Copy link
Member

@miniak what was the motivation for this change? I'd potentially like to avoid adding methods to modules with no clear community requests or identified use cases 🤔

@miniak
Copy link
Contributor Author
miniak commented Mar 14, 2019

@codebytere we would like to use this API in Teams to adjust our animations

MarshallOfSound
MarshallOfSound reviewed Mar 14, 2019
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 15, 2019
@codebytere codebytere added the semver/minor backwards-compatible functionality label Mar 15, 2019
@MarshallOfSound MarshallOfSound merged commit 4c51fa9 into master Mar 19, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 19, 2019 •
edited by MarshallOfSound
Loading

Release Notes Persisted

Added a new systemPreferences.getAnimationSettings() API that returns the system animation settings provided by Chromium. Useful to determine what kinda of animation your app should use.

@MarshallOfSound MarshallOfSound deleted the miniak/get-animation-settings branch March 19, 2019 19:15
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
feat: add systemPreferences.getAnimationSettings() (electron#17382)
e7ed766
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@codebytere codebytere codebytere approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

@alexeykuzmin alexeykuzmin Awaiting requested review from alexeykuzmin

Assignees

@miniak miniak

Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @codebytere @MarshallOfSound @ppontes
0