8000 refactor: make applicationMenu a property on app by codebytere · Pull Request #17361 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: make applicationMenu a property on app #17361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 2, 2019
Merged

refactor: make applicationMenu a property on app #17361

merged 1 commit into from
Apr 2, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 12, 2019 •
edited
Loading

Description of Change

This PR converts applicationMenu to a proper JS property on app, so that users can use get and set on properties instead of using getApplicationMenu and setApplicationMenu.

cc @MarshallOfSound @nornagon @miniak

Checklist

Release Notes

Notes: Converted applicationMenu to a proper JS property on the app module.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 12, 2019
@codebytere codebytere added the semver/major incompatible API changes label Mar 12, 2019
@codebytere codebytere changed the title refactor: make applicationMenu a property on app [wip] refactor: make applicationMenu a property on app Mar 13, 2019
@codebytere codebytere changed the title [wip] refactor: make applicationMenu a property on app refactor: make applicationMenu a property on app Mar 13, 2019
@codebytere codebytere added semver/minor backwards-compatible functionality wip ⚒ and removed semver/major incompatible API changes labels Mar 13, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 13, 2019
@codebytere codebytere removed the wip ⚒ label Apr 2, 2019
@codebytere codebytere merged commit 0431997 into master Apr 2, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 2, 2019

Release Notes Persisted

Converted applicationMenu to a proper JS property on the app module.

@codebytere codebytere deleted the app-appmenu-prop branch April 2, 2019 20:37
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
refactor: make applicationMenu a property on app (electron#17361)
6d40ae0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @MarshallOfSound
0