8000 feat: promisify In-App Purchase by codebytere · Pull Request #17355 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: promisify In-App Purchase #17355

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 13, 2019
Merged

feat: promisify In-App Purchase #17355

merged 2 commits into from
Mar 13, 2019

Conversation

codebytere
Copy link
Member
@codebytere codebytere commented Mar 12, 2019 •
edited
Loading

Description of Change

Promisifies inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

Checklist

Release Notes

Notes: Promisified inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 12, 2019
@codebytere codebytere marked this pull request as ready for review March 12, 2019 18:03
miniak
miniak requested changes Mar 12, 2019
View reviewed changes
Copy link
Contributor
@miniak miniak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing deprecate.promisify in lib/browser/api/in-app-purchase.js

@codebytere codebytere added semver/minor backwards-compatible functionality semver/major incompatible API changes and removed semver/major incompatible API changes labels Mar 12, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 13, 2019
@codebytere codebytere merged commit 3e5a98b into master Mar 13, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 13, 2019

Release Notes Persisted

Promisified inAppPurchase.getProducts() and inAppPurchase.purchaseProduct().

@codebytere codebytere deleted the promisify-iap branch March 13, 2019 20:56
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@codebytere @kiku-jw
feat: promisify In-App Purchase (electron#17355)
c6362e5 
* feat: promisify In-App Purchase

* use mate::Arguments in GetProducts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@miniak miniak miniak approved these changes

@zcbenz zcbenz Awaiting requested review from zcbenz

Assignees
No one assigned
Labels
semver/minor backwards-compatible functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebytere @deepak1556 @miniak
0