10000 refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async by miniak · Pull Request #17235 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async #17235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 6, 2019
Merged

refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async #17235

merged 1 commit into from
Mar 6, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Mar 5, 2019

Description of Change

Follow up to "feat: promisify dialog.showOpenDialog()" #16973

Checklist

  • PR description included and stakeholders cc'd
  • npm test passes
  • PR title follows semantic commit guidelines

/cc @codebytere

Release Notes

Notes: no-notes

@miniak miniak requested a review from codebytere March 5, 2019 19:39
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Mar 5, 2019
@miniak miniak force-pushed the miniak/inspector-select-file branch from 9aeb734 to 90ff639 Compare March 5, 2019 19:40
@miniak miniak self-assigned this Mar 5, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Mar 6, 2019
@alexeykuzmin alexeykuzmin merged commit 2733697 into master Mar 6, 2019
@release-clerk
Copy link
release-clerk bot commented Mar 6, 2019

No Release Notes

@miniak miniak deleted the miniak/inspector-select-file branch March 14, 2019 10:43
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
refactor: make ELECTRON_INSPECTOR_SELECT_FILE handler async (electron…
3618711 
…#17235)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@miniak @alexeykuzmin @MarshallOfSound @ppontes
0