feat: add 'disableHtmlFullscreenWindowResize' option to webPreferences #17203
Conversation
There was a problem hiding this comment.
Calling preventDefault on will-enter-html-full-screen doesn't make a whole log of sense to not cancel the full screen, rather just change it's behavior.
I'd rather add a flag in webPreferences to change the behavior of this for the entire webContents (which would appear to fit your use case.
This option allows users to prevent the window from resizing when the HTML5 FullScreen API is used.
f9fdee1 to
4f0a307
Compare
Agreed.
@MarshallOfSound I've implemented these changes, how'd I do? |
|
Release Notes Persisted
|
electron#17203) This option allows users to prevent the window from resizing when the HTML5 FullScreen API is used.
Description of Change
Adds an option to
webPreferencesnameddisableHtmlFullscreenWindowResize. If set totrue, the window will retain its size when using the HTML5 Fullscreen API. The requested HTML element will still fullscreen within the viewport though.This is a fairly specialized use case for my application, Metastream. I'd like to be able to trigger HTML5 fullscreen without causing the window to resize. An example can be seen in the following GIF.
Checklist
npm testpassesRelease Notes
Notes: Added
disableHtmlFullscreenWindowResizeoption towebPreferencesto allow preventing window from resizing when entering HTML5 fullscreen.