8000 chore: properly template the Then promise helper by codebytere · Pull Request #17050 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore: properly template the Then promise helper #17050

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 19, 2019
Merged

chore: properly template the Then promise helper #17050

merged 1 commit into from
Feb 19, 2019

Conversation

codebytere
Copy link
Member

Description of Change

We can't pass a base::Closure into the Promise util Then helper because that assumes a callback with no parameters or no unbound parameters, and more often than not the passed callback will have several unbound parameters. We thus need to template this helper with the ReturnType and ArgTypes.

cc @MarshallOfSound

Checklist

Release Notes

Notes: none

@codebytere codebytere requested a review from a team February 19, 2019 13:47
This was referenced Feb 19, 2019
Merged
Merged
ckerr
ckerr approved these changes Feb 19, 2019
View reviewed changes
Copy link
Member
@ckerr ckerr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codebytere codebytere merged commit cc5ed24 into master Feb 19, 2019
@release-clerk
Copy link
release-clerk bot commented Feb 19, 2019

No Release Notes

@codebytere codebytere deleted the template-then-helper branch February 19, 2019 21:47
@trop trop bot mentioned this pull request Feb 19, 2019
Merged
@trop
Copy link
Contributor
trop bot commented Feb 19, 2019

I have automatically backported this PR to "5-0-x", please check out #17058

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ckerr ckerr ckerr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@codebytere @ckerr
0