8000 fix: skip zygote for unsandboxed ppapi processes by nornagon · Pull Request #17823 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: skip zygote for unsandboxed ppapi processes #17823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 16, 2019
Merged

fix: skip zygote for unsandboxed ppapi processes #17823

merged 1 commit into from
Apr 16, 2019

Conversation

nornagon
Copy link
Contributor

Description of Change

Fixes #17034.

The sequence of events here was:

  1. The main process starts
  2. Early in the initialization sequence, before main.js is run, content spawns a zygote and initializes the sandbox
  3. main.js runs, and adds --no-sandbox to the command-line flags
  4. The renderer boots and requests a ppapi process
  5. The ppapi process is forked from the zygote, which already has the sandbox pre-initialized, since it was warmed up before the --no-sandbox flag was added.

With this patch, we intervene before (5) and re-check the command-line flags. If --no-sandbox is present, we do not launch from the zygote, and instead spawn a fresh process without the sandbox.

This patch is similar to the one that supports mixed-sandbox mode.

Checklist

Release Notes

Notes: Fixed an issue preventing the Flash plugin from loading on Linux.

@nornagon nornagon requested a review from a team as a code owner April 16, 2019 18:43
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 16, 2019
@nornagon
Copy link
Contributor Author

linux failure is flake; merging.

@nornagon nornagon merged commit 33fd200 into master Apr 16, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 16, 2019

Release Notes Persisted

Fixed an issue preventing the Flash plugin from loading on Linux.

@nornagon nornagon deleted the ppapi-zygote-no-sandbox branch April 16, 2019 22:32
@trop
Copy link
Contributor
trop bot commented Apr 16, 2019

I was unable to backport this PR to "5-0-x" cleanly;
you will need to perform this backport manually.

@nornagon nornagon mentioned this pull request Apr 16, 2019
Merged
@trop
Copy link
Contributor
trop bot commented Apr 16, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17829

1 similar comment
@trop
Copy link
Contributor
trop bot commented Apr 17, 2019

A maintainer has manually backported this PR to "5-0-x", please check out #17829

kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@nornagon @kiku-jw
fix: skip zygote 8000 for unsandboxed ppapi processes (electron#17823)
ba33cbe
@miniak miniak mentioned this pull request Jun 22, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepak1556 deepak1556 deepak1556 approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Linux Flash Plugin not loading
4 participants
@nornagon @deepak1556 @MarshallOfSound @codebytere
0