8000 fix: crash when alt key pressed with falsy menu bar visiblity (backport: 5-0-x) by trop[bot] · Pull Request #17795 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: crash when alt key pressed with falsy menu bar visiblity (backport: 5-0-x) #17795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 15, 2019
Merged

fix: crash when alt key pressed with falsy menu bar visiblity (backport: 5-0-x) #17795

merged 1 commit into from
Apr 15, 2019

Conversation

trop[bot]
Copy link
Contributor
@trop trop bot commented Apr 15, 2019

Backport of #17766

See that PR for details.

Notes: Fixed crash when pressing Alt key with setMenuBarVisibility to false.

@trop trop bot mentioned this pull request Apr 15, 2019
Merged
4 tasks
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 15, 2019
@trop trop bot added 5-0-x backport This is a backport PR labels Apr 15, 2019
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 15, 2019
@jkleinsc jkleinsc merged commit 119e8be into electron:5-0-x Apr 15, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 15, 2019

Release Notes Persisted

Fixed crash when pressing Alt key with setMenuBarVisibility to false.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

Assignees
No one assigned
Labels
5-0-x backport This is a backport PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarshallOfSound @jkleinsc @vhashimotoo
0