8000 feat: add webContents 'zoom-changed' event by miniak · Pull Request #17747 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: add webContents 'zoom-changed' event #17747

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 14, 2019
Merged

feat: add webContents 'zoom-changed' event #17747

merged 5 commits into from
May 14, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Apr 10, 2019 •
edited
Loading

Description of Change

Emit zoom-changed event when the user is trying to zoom in / out using the mouse wheel on Windows. This is the only way the Electron app will be able to handle these events when the focus is inside a (x-origin) iframe.

Checklist

Release Notes

Notes: Added zoom-changed event to webContents, which is emitted when the user is trying to zoom in / out using the mouse wheel on Windows, even if the focus is inside an (x-origin) iframe.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 10, 2019
@miniak miniak force-pushed the miniak/zoom-changed branch from bdb4ce4 to 87f170d Compare April 10, 2019 18:04
@ppontes ppontes force-pushed the miniak/zoom-changed branch from 248799f to 31c019b Compare April 11, 2019 07:39
@ppontes ppontes mentioned this pull request Apr 11, 2019
Merged
4 tasks
miniak
miniak commented Apr 11, 2019
View reviewed changes
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 11, 2019
@ppontes ppontes force-pushed the miniak/zoom-changed branch from 31c019b to 280bdad Compare April 12, 2019 12:26
@miniak miniak force-pushed the miniak/zoom-changed branch from 280bdad to 64b278c Compare April 16, 2019 16:54
@miniak miniak marked this pull request as ready for review April 16, 2019 16:54 8000
@miniak miniak assigned ppontes and miniak and unassigned ppontes Apr 16, 2019
codebytere
codebytere requested changes Apr 17, 2019
View reviewed changes
Copy link
Member
@codebytere codebytere left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs documentation :)

MarshallOfSound
MarshallOfSound reviewed Apr 23, 2019
View reviewed changes
@ppontes ppontes force-pushed the miniak/zoom-changed branch from 64b278c to a6e6c63 Compare April 26, 2019 16:42
@miniak miniak force-pushed the miniak/zoom-changed branch from a6e6c63 to fd9700c Compare April 27, 2019 16:28
miniak
miniak commented Apr 29, 2019
View reviewed changes
@miniak miniak force-pushed the miniak/zoom-changed branch from fd9700c to 6c13cd0 Compare May 2, 2019 14:47
@miniak miniak requested review from MarshallOfSound, ppontes and codebytere and removed request for ppontes May 2, 2019 14:47
alexeykuzmin
alexeykuzmin suggested changes May 2, 2019
View reviewed changes
@miniak miniak requested a review from alexeykuzmin May 2, 2019 16:51
miniak and others added 3 commits May 3, 2019 09:25
@miniak
feat: add webContents 'zoom-changed' event
a7c0b5f
@ppontes @miniak
test: "zoom-changed" event emission from webContents when user zooms …
d143739 
…with the mouse wheel.

Should only go in when Electron has webContents.sendInputContent fixed so that it properly creates
a WebMouseWheelEvent.
@ppontes @miniak
refactor: zoom-changed event represents zoom direction with ZoomDirec…
45ec57c 
…tion.
@miniak miniak force-pushed the miniak/zoom-changed branch from 41b522d to 9de5ae1 Compare May 3, 2019 07:37
@miniak
Copy link
Contributor Author
miniak commented May 6, 2019

@MarshallOfSound are you ok with the current state of the PR?

MarshallOfSound
MarshallOfSound approved these changes May 13, 2019
View reviewed changes
Copy link
Member
@MarshallOfSound MarshallOfSound left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not the hugest fan of the API but better than before and I don't think given the API we're working with we can do much better

@alexeykuzmin alexeykuzmin merged commit 6609138 into master May 14, 2019
@release-clerk
Copy link
release-clerk bot commented May 14, 2019

Release Notes Persisted

Added zoom-changed event to webContents, which is emitted when the user is trying to zoom in / out using the mouse wheel on Windows, even if the focus is inside an (x-origin) iframe.

@alexeykuzmin alexeykuzmin deleted the miniak/zoom-changed branch May 14, 2019 06:41
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
feat: add webContents 'zoom-changed' event (electron#17747)
cc72da4
@pfrazee pfrazee mentioned this pull request Jun 23, 2020
Closed
@vanowm
Copy link
vanowm commented Jan 2, 2022 •
edited
Loading

What about zoom changed by menuItem with role zoomReset, zoomIn and zoomOut, is there an event for these?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

@codebytere codebytere Awaiting requested review from codebytere

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@miniak @vanowm @alexeykuzmin @codebytere @MarshallOfSound @ppontes
0