fix: ensure the sandboxed preloads globals do not leak #17712
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nornagon
suggested changes
Apr 5, 2019
e5f533a to
fa8203c
Compare
nornagon
approved these changes
Apr 16, 2019
fa8203c to
0531d8b
Compare
|
Release Notes Persisted
|
|
@MarshallOfSound this is gonna need manual bp to |
|
I was unable to backport this PR to "5-0-x" cleanly; |
|
A maintainer has manually backported this PR to "5-0-x", please check out #17830 |
MarshallOfSound
added a commit
that referenced
this pull request
Apr 17, 2019
|
A maintainer has manually backported this PR to "5-0-x", please check out #17830 |
kiku-jw
pushed a commit
to kiku-jw/electron
that referenced
this pull request
May 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change
This PR re-adds the preload wrapping we used to have for sandboxed renderers that was accidentally removed as part of C71. It takes a different approach partially due to API changes in node and partially for performance reasons. Instead of wrapping the script at runtime, we wrap the scripts at build time.
This PR enables the
--standaloneflag for our browserify builds and then wraps the scripts with a fakemodule: { exports }. Standalone will ensure nothing leaks and the fake exports will ensure that nothing gets injected onto thewindowobject 👍Release Notes
Notes: Fixed issue where sandboxed renderers could sometimes leak globals outside of the preload script