8000 fix: emit process 'loaded' event in sandboxed renderers by miniak · Pull Request #17680 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

fix: emit process 'loaded' event in sandboxed renderers #17680

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2019
Merged

fix: emit process 'loaded' event in sandboxed renderers #17680

merged 1 commit into from
Apr 4, 2019

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Apr 3, 2019 •
edited
Loading

Description of Change

Makes it consistent with non-sandboxed renderer behavior.

Checklist

Release Notes

Notes: Fixed 'loaded' event not being emitted in sandboxed renderers.

@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 3, 2019
@miniak miniak force-pushed the miniak/process-loaded-sandbox branch from e1b074a to 3951969 Compare April 3, 2019 16:17
@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 4, 2019
@MarshallOfSound MarshallOfSound merged commit 77d59e9 into master Apr 4, 2019
@release-clerk
Copy link
release-clerk bot commented Apr 4, 2019

Release Notes Persisted

Process now emits 'loaded' event in sandboxed renderers.

@MarshallOfSound MarshallOfSound deleted the miniak/process-loaded-sandbox branch April 4, 2019 18:35
This was referenced Apr 16, 2019
Merged
Merged
Merged
@miniak miniak cha 84B4 nged the title feat: emit process 'loaded' event in sandboxed renderers fix: emit process 'loaded' event in sandboxed renderers Apr 16, 2019
kiku-jw pushed a commit to kiku-jw/electron that referenced this pull request May 16, 2019
@miniak @kiku-jw
feat: emit process 'loaded' event in sandboxed renderers (electron#17680
2f6e37e 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound approved these changes

@ppontes ppontes ppontes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @MarshallOfSound @ppontes
0