8000 docs: process.getProcessMemoryInfo() returns a Promise (backport: 4-1-x) by miniak · Pull Request #17673 · electron/electron · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

docs: process.getProcessMemoryInfo() returns a Promise (backport: 4-1-x) #17673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

docs: process.getProcessMemoryInfo() returns a Promise (backport: 4-1-x) #17673

wants to merge 1 commit into from

Conversation

miniak
Copy link
Contributor
@miniak miniak commented Apr 3, 2019 •
edited
Loading

Description of Change

Backport #16593

Checklist

Release Notes

Notes: Fixed process.getProcessMemoryInfo() return type to Promise<ProcessMemoryInfo> in electron.d.ts.

@miniak miniak requested a review from MarshallOfSound April 3, 2019 10:54
@electron-cation electron-cation bot added the new-pr 🌱 PR opened recently label Apr 3, 2019
@miniak miniak self-assigned this Apr 3, 2019
MarshallOfSound
MarshallOfSound requested changes Apr 3, 2019
View reviewed changes
package.json
"electron-docs-linter": "^2.4.0",
"electron-typescript-definitions": "^2.1.1",
"electron-docs-linter": "^3.0.1",
"electron-typescript-definitions": "^8.2.2",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not safe

This completely changes how events are documented and thus would break the generated definitions

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any suggestions how to do it in a safe way?

@electron-cation electron-cation bot removed the new-pr 🌱 PR opened recently label Apr 4, 2019
@miniak miniak closed this Apr 9, 2019
@miniak miniak deleted the miniak/doc-fix-process-memory-info-4-1-x branch May 4, 2019 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarshallOfSound MarshallOfSound MarshallOfSound requested changes

@alexeykuzmin alexeykuzmin alexeykuzmin approved these changes

Assignees

@miniak miniak

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miniak @alexeykuzmin @MarshallOfSound
0